Revert "Turn on SPIR-V builtin generation for OpenCL CPP sources (#2466)" #2508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onosGroup#2466)" This reverts commit 80dfd86. The commit break Translator in cases when user supplied function is named with the prefix which, after demangling, is the same as OpenCL builtin. The culprit code is placed in during SPIRWriter OCL pass in OCLToSPIRVBase::visitCallInst(CallInst &). Failing name would be for example atomic_fetch_and_sub_uint32_explicit.
bwlodarcz
requested review from
LU-JOHN,
MrSidims,
VyacheslavLevytskyy,
asudarsa,
svenvh and
vmaksimo
MrSidims
approved these changes
Apr 18, 2024
|
I am trying to check if this is a OpenCL C++ specific problem or if this issue can be reproduced in OpenCL C. Will revert once confirmed as a OpenCL C++ specific problem. Thanks |
|
Hi @svenvh, We tested my change #2512 and all our existing test failures are resolved. This particular change (OCLToSPIRV for OpenCL C++) is important for one of our compilation flows. I would prefer to keep this in and continue discussion about covering user-declared functions. Thanks |
Can it be moved to downstream then? |
maarquitos14
added a commit
to maarquitos14/SPIRV-LLVM-Translator
that referenced
this pull request
Feb 27, 2025
…ces (KhronosGroup#2466)" (KhronosGroup#2508)" This reverts commit 9e60105.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 80dfd86. The commit breaks Translator in cases when user supplied function is named with the same prefix, after demangling, as OpenCL builtin. The culprit code is in SPIRWriter OCL pass in function OCLToSPIRVBase::visitCallInst(CallInst &).
Failing name would be for example atomic_fetch_and_sub_uint32_explicit.